Improve performance by using Python C API to enter/exit context#627
Merged
Conversation
tarasko
force-pushed
the
optimize_run_in_context
branch
2 times, most recently
from
September 10, 2024 23:17
0701321 to
1757aa8
Compare
tarasko
force-pushed
the
optimize_run_in_context
branch
2 times, most recently
from
September 11, 2024 00:26
64459a4 to
1721fb9
Compare
tarasko
force-pushed
the
optimize_run_in_context
branch
from
September 11, 2024 00:45
1721fb9 to
b5873d5
Compare
fantix
approved these changes
Jan 27, 2026
fantix
left a comment
Member
There was a problem hiding this comment.
On a side note, I have removed Py_INCREF/Py_DECREF because cython does it itself when method is called directly.
Yes, INCREF/DECREF was added in #399 as a temporary fix for Python 3.9 and lower. Now that Python 3.9 is EOL, it is safe to drop this temporary fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From perf, callstack before the change:
After the change:
On a side note, I have removed Py_INCREF/Py_DECREF because cython does it itself when method is called directly.